Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ice Ice Bergy theme #1472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Ice Ice Bergy theme #1472

wants to merge 1 commit into from

Conversation

jmsdnns
Copy link

@jmsdnns jmsdnns commented Sep 30, 2024

Similar to Iceberg, but I find it's easier on the eyes. Screenshots available here: https://github.com/jmsdnns/zed-iceicebergy.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
@jmsdnns
Copy link
Author

jmsdnns commented Oct 1, 2024

Hmm. From what I can tell, the check didn't fail because of my theme. The log output suggests it is something to do with a package called kanagawa-themes.

Packaging 'iceicebergy'. Version: 0.3.14
Checking out Git submodule at 'extensions/iceicebergy'

Packaging 'kanagawa-themes'. Version: 0.0.1
Checking out Git submodule at 'extensions/kanagawa-themes'
file:///home/runner/work/extensions/extensions/src/package-extensions.js:148
    throw new Error(
          ^

Error: The `extension.json` manifest format has been superseded by `extension.toml`
    at packageExtension (file:///home/runner/work/extensions/extensions/src/package-extensions.js:148:11)
    at async file:///home/runner/work/extensions/extensions/src/package-extensions.js:119:5

Node.js v20.17.0
 ELIFECYCLE  Command failed with exit code 1.

@jmsdnns
Copy link
Author

jmsdnns commented Oct 1, 2024

To simplify things, the error says to use extension.toml. The one in my theme is right here: https://github.com/jmsdnns/zed-iceicebergy/blob/main/extension.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmsdnns